Merge pull request #224 from twokul/fix

Fix presets array bug
emberjs · May 26, 2018 · 194c847 · 194c847
2 parents fcc6c89 + 18c751d
commit 194c847
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -223,7 +223,7 @@ module.exports = {
 
     options.presets = [
       shouldRunPresetEnv && this._getPresetEnvPlugins(addonProvidedConfig),
-    ]
+    ].filter(Boolean);
 
     if (shouldCompileModules) {
       options.moduleIds = true;

diff --git a/node-tests/addon-test.js b/node-tests/addon-test.js
@@ -791,6 +791,24 @@ describe('ember-cli-babel', function() {
       expect(result.plugins).to.deep.include(plugin);
     });
 
+    it('sets `presets` to empty array if `disablePresetEnv` is true', function() {
+      let options = {
+        'ember-cli-babel': {
+          disablePresetEnv: true,
+        }
+      };
+      this.addon.parent = {
+        options: {
+          babel6: {
+            plugins: [ {} ]
+          },
+        },
+      };
+
+      let result = this.addon.buildBabelOptions(options);
+      expect(result.presets).to.deep.equal([]);
+    });
+
     it('user plugins are before preset-env plugins', function() {
       let plugin = function Plugin() {};
       this.addon.parent = {