Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move babel specific options into options.babel property. #189

Closed
rwjblue opened this issue Oct 9, 2020 · 1 comment · Fixed by #193
Closed

Move babel specific options into options.babel property. #189

rwjblue opened this issue Oct 9, 2020 · 1 comment · Fixed by #193
Milestone

Comments

@rwjblue
Copy link
Member

rwjblue commented Oct 9, 2020

Currently we try to treat this packages options as both Broccoli specific options and Babel's options. This is quite painful (passing another option to the Broccoli plugin is actually a breaking change for the babel transpilation side of things) and not terribly useful.

We should refactor our incoming options to move the babel specific options into options.babel so that we can delete the following munging of options:

delete options.persist;
delete options.async;
delete options.annotation;
delete options.description;
this._optionsHash = null;
this.console = options.console || console;
this.throwUnlessParallelizable = options.throwUnlessParallelizable;
delete options.console;
delete options.throwUnlessParallelizable;

@nlfurniss
Copy link
Contributor

I can take this on in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants