-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need logging to explain changes to the plugins spec #10
Comments
wait, the default for that isn’t spec anymore?? |
Sorry if it doesn't make sense. The v7 default was what was previously spec |
Maybe I’m missing context. I’d hope that v7 had more things default to “spec” than in v6; but maybe this issue is about the more generic approach of how to adapt to changing defaults? |
I'm saying what you are saying, in v7 more things are spec, but that might be unexpected to certain lib authors that didn't want to opt-in to that when they were using loose before. |
Makes sense, thanks for clarifying :-) |
@hzoo i can take a swing at this. thinking about how to most clearly word these notifications 🤔🤔🤔 maybe something like: - i don't like "For previous behavior" -- not sure how to articulate that bit |
@hzoo are there any plugins other than the following that are hit here?
i haven't yet dug into the code on these to understand completely, but it looks like there were some behavior changes around adding a
should we provide some sort of logging on these also? also -- any thoughts on how this should factor in for users who have loose/spec set on a preset instead of on the standalone plugin? perhaps that's a little bigger than this issue, i need to think more about what might make sense there edit: oh, that's what you were referring to when you said "explicitly", i get it now 👍 |
Basically people are going to complain because the output from babel after updating may be larger than before because the defaults are spec behavior.
Example:
-
template-literals
- default was previously "spec" ->'a' + b
->"a".concat(b)
The text was updated successfully, but these errors were encountered: