fix deprecation warning #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes deprecation warning for webpack 2.x+ while also keeps on working with older webpack versions. DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see (https://github.com/webpack/loader-utils/issues/56)[https://github.com/webpack/loader-utils/issues/56] parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
|
I've seen some other pull requests, but they imply breaking changes, since older versionf of loader-utils don't have |
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
==========================================
- Coverage 83.03% 82.42% -0.61%
==========================================
Files 6 6
Lines 165 165
Branches 38 39 +1
==========================================
- Hits 137 136 -1
Misses 12 12
- Partials 16 17 +1
Continue to review full report at Codecov.
|
|
duplicate #391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation warning for webpack 2.x+ while also keeps on working with older webpack versions.
DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see (https://github.com/webpack/loader-utils/issues/56)[https://github.com/webpack/loader-utils/issues/56]
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information: