Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Add query namespace support #10

Closed
mprokopov opened this issue Dec 18, 2021 · 16 comments
Closed

Add query namespace support #10

mprokopov opened this issue Dec 18, 2021 · 16 comments

Comments

@mprokopov
Copy link
Contributor

http://etaoin.grishaev.me/etaoin.query.html

It would be nice to have query namespace as well in babashka-etaoin pod.

@borkdude
Copy link
Contributor

Feel free to add

@borkdude
Copy link
Contributor

I'll wait for this one before the next release

@borkdude
Copy link
Contributor

I'm wondering if we should expose this since etaoin has an explicit api and api2 namespace. If these functions are not exposed through the API maybe they are considered to not be part of the API?

/cc @igrishaev

@borkdude
Copy link
Contributor

borkdude commented Jan 9, 2022

I haven't had an answer, so I'd say, let's just expose it.

@igrishaev
Copy link

Sorry @borkdude I was on my NY holidays. It's OK to expose the query namespace.

@igrishaev
Copy link

Actually, the primary namespace in Etaoin is the .api one. The .api2 carries the new versions of macros that cannot be fixed in the .api without breaking the things. The .api namespace requires the .query ns.

@borkdude
Copy link
Contributor

@igrishaev Thank you for the reply! Are you saying that the query functions are available already in the API ns?

@igrishaev
Copy link

@borkdude
Copy link
Contributor

Yes, the API namespaces uses the query namespace, but this isn't what I'm asking. I'm asking if it exposes the query namespace. So if you want to use a function from query, is it available via API?

@igrishaev
Copy link

Well, it looks like query functions are available only from the .query ns. I'm a bit unsure what does the expose word mean. Did you mean something like:

;; api.clj

(def expand query/expand)
;; and so on?

@borkdude
Copy link
Contributor

Yes, that's what I mean :) If there is an API, I would expect all functions that are intended as the API to be available there, but I could be wrong.

@igrishaev
Copy link

Well, it's not so at the moment. Should a user need any of the .query functions, he or she needs to require it manually. Does it cause an issue for the babashka pod?

@borkdude
Copy link
Contributor

No not at all. My only question was: is that etaoin.query namespace intended to be used by library users, given that you also have an explicit api namespace. It seems the answer is still yes. So let's expose it in the pod.

@borkdude
Copy link
Contributor

@mprokopov I added query/expand to the master branch now. Is this the only var you want, or are there more?

@mprokopov
Copy link
Contributor Author

Looks great, @borkdude!
This is totally enough and thanks for your efforts!

@borkdude
Copy link
Contributor

@mprokopov This is released now as 0.1.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants