Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-jar-test breaks when new org.babashka/http-server is published #90

Open
rads opened this issue Oct 20, 2024 · 3 comments
Open

maven-jar-test breaks when new org.babashka/http-server is published #90

rads opened this issue Oct 20, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@rads
Copy link
Collaborator

rads commented Oct 20, 2024

I noticed this when I was bringing #74 up-to-date with main.

To make this test more stable, I think we could set up bbin-test-lib to publish a couple versions to Clojars so the latest published version will only change when we want it to.

(@borkdude: Should we also move bbin-test-lib to the babashka GitHub org?)

@rads rads added the bug Something isn't working label Oct 20, 2024
@borkdude
Copy link
Contributor

(@borkdude: Should we also move bbin-test-lib to the babashka GitHub org?)

Perhaps it's possible to move this library inside the bbin repo? We can use it with :deps/root

@rads
Copy link
Collaborator Author

rads commented Oct 20, 2024

For this particular issue with the Maven dependency, we could publish a test JAR from a folder within the bbin repo instead of bbin-test-lib and it wouldn't change anything since the test will pull from Clojars anyways.

My intent with the tests using bbin-test-lib (such as git-dir-test) is to make sure the install commands work with things like public vs private repos, and tags vs no tags. It's meant as an end-to-end test so I think replicating the tests within the same repo might be tricky. Perhaps we should move the bbin-test-lib discussion to a separate issue?

@borkdude
Copy link
Contributor

borkdude commented Oct 21, 2024

Perhaps we should move the bbin-test-lib discussion to a separate issue?

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants