Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLDAModel does not accept user defined values for the "nu_sq" parameter #173

Closed
jucendrero opened this issue Jul 8, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@jucendrero
Copy link
Contributor

jucendrero commented Jul 8, 2022

I'm choosing different values for the nu_sq parameter of the SLDAModel and I always get the same error:

RuntimeError: src/TopicModel/SLDAModel.hpp (392): wrong nuSq value (len = 1).

The problem is that, in src/TopicModel/SLDAModel.hpp, lines 378 - 394, the first if statement makes reference to args.nuSq, but the following else if statements make reference to args.mu instead. Therefore, the only valid option for the nu_sq parameter is an empty list, which is the default value.

I think this was a typo and the error would be fixed if the else if statements were else if (args.nuSq.size() == 1) and else if (args.nuSq.size() == F) instead.

@bab2min
Copy link
Owner

bab2min commented Jul 9, 2022

Hi @jucendrero, thank you for reporting bug. Yes, it is a typo.
After some checks, I'll accept your patch!

@jucendrero
Copy link
Contributor Author

Thank you @bab2min! I see that the pull request has been merged, so I’m closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants