Integral types

[kc9jud]

Is there a reason why Discrete.h uses std::is_same rather than std::is_integral here?

EigenRand/EigenRand/Dists/Discrete.h

Line 217 in f3190cd

static_assert(std::is_same<_Scalar, int32_t>::value, "uniformInt needs integral types.");

If this is instead std::is_integral<_Scalar>::value, then the discrete generators can also be used for int64_t, uint32_t, etc.

[kc9jud]

Would this line:

EigenRand/EigenRand/Dists/Discrete.h

Line 268 in f3190cd

if (bitcnt + bitsize < 32)

need to change to if (bitcnt + bitsize < CHAR_BIT*sizeof(_Scalar))?

[kc9jud]

As I look further, it seems like there are a decent number of places where other types/constants need to become sizeof-dependent. Is this of interest?

[bab2min]

Hi @kc9jud , thank you for your interest in this repository.
It is because Discrete generators use some specialized routine for int32_t SIMD.
At the time of first implementation, only int32_t was considered, so additional implementations were required to make it work for other integral types.
I will add support for other integral types in future updates.