fix(optional): allows blank values in optional keys #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3ross
previously approved these changes
Apr 9, 2020
b3ross
reviewed
Apr 9, 2020
| @@ -16,10 +16,10 @@ export function parse(contents: string, stage?: string): InputDocument { | |||
| const value = document[key]; | |||
| if (typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean') { | |||
| result[key] = { value: value }; | |||
| } else if (value.optional && value.value) { | |||
| } else if (value.optional && typeof value.value !== 'undefined') { | |||
There was a problem hiding this comment.
Any reason for using typeof here instead of just checking for undefined? Any issue with swapping that out?
There was a problem hiding this comment.
It’s the safest way to do this check. undefined can actually be reassigned so this has been established at the best practice.
https://stackoverflow.com/questions/4725603/variable-undefined-vs-typeof-variable-undefined
Happy to change if you want though.
There was a problem hiding this comment.
God I hate JavaScript sometimes lol
b3ross
approved these changes
Apr 9, 2020
|
🎉 This PR is included in version 0.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #61