Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Nothing happen while executing !rbp stationID #138

Closed
riauas opened this issue Apr 30, 2020 · 9 comments
Closed

Nothing happen while executing !rbp stationID #138

riauas opened this issue Apr 30, 2020 · 9 comments

Comments

@riauas
Copy link

riauas commented Apr 30, 2020

It always happen after querying radio streaming and want to playing particular radio by using cmd !rbp stationID. Currently using botamusique ver 6.2 latest release 5fbc8e4

The log says about it:
[Apr 25 18:18:25 INFO Thread-2] bot: rbp matches rbplay
[Apr 25 18:18:25 ERROR Thread-2] bot: command rbplay failed with error: Traceback (most recent call last):
File "mumbleBot.py", line 298, in message_received
self.cmd_handle[command_exc]['handle'](self, user, text, command_exc, parameter)
File "/home/XxX/Downloads/botamusique/command.py", line 475, in cmd_rb_play
url = radiobrowser.geturl_byid(parameter)
File "/home/XxX/Downloads/botamusique/librb/radiobrowser.py", line 19, in geturl_byid
url = rb.playable_station(id)['url']
KeyError: 'url'

@TerryGeng
Copy link
Collaborator

This is probably caused by we using a deprecated library of radiobrowser.info.

It seems that newer version of the python library https://pypi.org/project/pyradios/ is available. I'm wondering that whether @elpatron68, the original maintainer of the radiobrowser part, is willing to help us update the library :).

@elpatron68
Copy link
Contributor

Hi @TerryGeng , I will try to find some time next week to have a look at the problem.

@azlux
Copy link
Owner

azlux commented Apr 30, 2020

Hi,
Terry is right, we use an "home made" code.
SInce the pyradios project have now a pypi version, we can switch to it.
But radiobrowser haven't force the new API, this command should work. Did you try another station ID for testing ?

@riauas
Copy link
Author

riauas commented Apr 30, 2020

Hi @azlux , yes i did.
I tried several radios, some of it run normal but another radio i tried ended with KeyError: 'url'

@elpatron68
Copy link
Contributor

I just tested rb with 3 of my favorite stations, no problems. The URLs from http://www.radio-browser.info/ are checked in regular intervals and are beeing marked as broken in the database if they don´t work. I don´t remember if my API calls check for the broken flag, will have a look at the code the next days.

@TerryGeng
Copy link
Collaborator

@riauas I think it would also be helpful if you provide the radio ID you used to reproduce this bug.

@riauas
Copy link
Author

riauas commented May 2, 2020

Hi @TerryGeng sorry for slow response, here are shortlist of the radio ID i've used to reproduce the bug: 120925, 120926, 120927, 96311, 101975

@TerryGeng TerryGeng added the bug label May 6, 2020
@felix91gr
Copy link
Contributor

This is probably caused by we using a deprecated library of radiobrowser.info.

It seems that newer version of the python library https://pypi.org/project/pyradios/ is available. I'm wondering that whether @elpatron68, the original maintainer of the radiobrowser part, is willing to help us update the library :).

Oh, it's great that you're already working on this. I just came in to say that http://www.radio-browser.info/webservice/ was deprecated, but you guys already know :3

@TerryGeng
Copy link
Collaborator

Hi, I'm wondering is there any progress about this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants