Switch to unpacked MPQs

[azihassan]

I was on the fence about using unpacked MPQs but this settles it for me. I'm hoping for some load time improvements too

[azihassan]

Reopening this because I suspect it's causing some strange visual issues. I'm gonna recompile the dreamcast branch with set(UNPACKED_MPQS OFF) to make sure

[azihassan]

I was cloning from main unpack_and_minify_mpq from main, but after switching to the 1.5.1 tag it started works again. I'll try bisecting before opening an issue tomorrow

[azihassan]

Bisect result

git bisect start
# status: waiting for both good and bad commits
# bad: [d354283df819f3551eb8034795413d445e005add] .github/workflows: Update upload-artifact
git bisect bad d354283df819f3551eb8034795413d445e005add
# status: waiting for good commit(s), bad commit known
# good: [e7ff2622ae733a5d7ae3d73c923cff593df6f19c] Bump zlib to 1.3
git bisect good e7ff2622ae733a5d7ae3d73c923cff593df6f19c
# good: [1f7c4458600566c121fd6e72bc7c0abf97f400c9] Remove unused sounds
git bisect good 1f7c4458600566c121fd6e72bc7c0abf97f400c9
# bad: [91802dadc309794c591d08ebc63d148c1ad4b68c] Bump dvl_gfx
git bisect bad 91802dadc309794c591d08ebc63d148c1ad4b68c
# good: [2e2b5666ca9441cf5a29fa53f1355832b98dd347] Remove bhit.wav (unused)
git bisect good 2e2b5666ca9441cf5a29fa53f1355832b98dd347
# first bad commit: [91802dadc309794c591d08ebc63d148c1ad4b68c] Bump dvl_gfx

Something changed in the underlying library between commits diasurgical/devilutionx-graphics-tools@64c0629 and diasurgical/devilutionx-graphics-tools@ae39773

[azihassan]

Commit 5f260010b0af26e9c453931f42edcb02ce894a16 segfaults with diabdat.mpq, commit diasurgical/devilutionx-graphics-tools@ae39773 unpacks it but causes the bug above

[azihassan]

My bad, it got fixed after updating the fork. There was a significant improvement in load times, but this check fails on the console when I load the game from an iso created with mksdiso. Since it's still needed for CDs burned with dcdib, I'll check both paths in the code.