Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the update of your code. #15

Open
dof-pikes opened this issue May 31, 2023 · 2 comments
Open

About the update of your code. #15

dof-pikes opened this issue May 31, 2023 · 2 comments

Comments

@dof-pikes
Copy link

I noticed that you made modifications to the code repository after several peers reported large Ped errors. In particular, you added https://github.com/azhuantou/HSSDA/blob/main/pcdet/models/detectors/pv_rcnn_ssl.py#L476.

Can you provide a rationale for making these changes? Would these modifications deviate from the content of the paper?

Thank you for your response.

@azhuantou
Copy link
Owner

Hi, thanks for your interests.

I'm not sure why some peers' reproduced results have lower Ped performance. My speculation is that the most likely reason is the generation of incorrect pseudo-labels. Therefore, I implemented this hard code to prevent such situations. This does not deviate from the original paper's idea. And I will make every effort to figure out why.

If you have any new discoveries, feel free to share them directly. Thank you!

@dof-pikes
Copy link
Author

I'm delighted by your prompt response, thank you for your dedication.

Masking Ped implies that the method lacks generalization?
Could you provide a detailed explanation of the functionality of this line of code?
https://github.com/azhuantou/HSSDA/blob/main/pcdet/models/detectors/pv_rcnn_ssl.py#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants