New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Core): Achievements #47

Merged

55Honey merged 1 commit into azerothcore:master from noisiver:achievement

Jul 5, 2022

noisiver commented Jun 26, 2022

Added AchievementMethods
Added GetId to AchievementMethods
Added OnAchiComplete to PlayerHooks

Tested with:

local PLAYER_ON_ACHIEVEMENT_COMPLETE = 45

local function OnAchiComplete(event, player, achievement)
    print(player:GetName()..' has completed achievement with id '..achievement:GetId())
end
RegisterPlayerEvent(PLAYER_ON_ACHIEVEMENT_COMPLETE, OnAchiComplete)

Note: I wanted to add GetName() to AchievementMethods but locale kept causing a segmentation fault so I'm holding off on that for now


          Achievements

e1cfccc

noisiver changed the title ~~Feat: Achievements~~ feat(Core): Achievements

Member

55Honey commented Jul 5, 2022

Tested, works as intended.

acidmanifesto approved these changes

View reviewed changes

55Honey merged commit efba901 into azerothcore:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet