-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No implementation for dynamic charmed spell cooldowns. #19187
Comments
Also rename |
Well the "correct" solution would be to tie it into SmartAI or something like it and not use a separate table, seeing as that seems to be what Blizz did. Obviously would require a lot of research/data entry though. |
SAI not that good though yikes |
Wouldn't having that in creature_template_spell be better? As it's right next to the given spell(s) in question. |
SAI not optimal I think, as Blizz seemed to use a different system for creature spells. In very old screenshots they used initial and repeat timers like SAI but later they seemed to move to a frequency + cooldown based system without explicit timers, so there'd not be any upper limit to timers. As for creature_template_spell I don't think so because it's a sniffed table, and if it had timers we'd see them. |
I believe it's the other way around. You can see that this screenshot (I believe taken during some Blizzcon) a window appearance of either Windows Vista or Windows 7 and includes min/max timers. In this screenshot (Iirc taken from the WoW Diary by John Staats), you can see an appearance of I believe some Windows 9x variant, and it includes frequency values. |
You can’t tie it to SAI because creatures don’t use SAI alone, they can also use other scripting engines |
Current Behaviour
Currently mind controlled/charmed creatures have either no cooldowns on their spells or they are enforced through
spell_cooldown_overrides
, acting as a SpellInfoCorrections table specifically for charmed spell cooldowns. Because of this, and the current structure of the aforementioned table, the cooldowns are restricted to a single cooldown time.Expected Blizzlike Behaviour
As I said in a comment:
Source
WoWEdit screenshots, Wrath Classic, conversations with other, smarter people
Steps to reproduce the problem
Extra Notes
No response
AC rev. hash/commit
c9725dd
Operating system
Windows 10 x64
Custom changes or Modules
mod-ptr-template
The text was updated successfully, but these errors were encountered: