Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want clickable cards to be more accessible #3396

Closed
danahertzberg opened this issue May 3, 2024 · 2 comments · Fixed by #3463
Closed

I want clickable cards to be more accessible #3396

danahertzberg opened this issue May 3, 2024 · 2 comments · Fixed by #3463
Assignees
Labels
accessibility bug Something isn't working enhancement New feature or request

Comments

@danahertzberg
Copy link
Contributor

danahertzberg commented May 3, 2024

Problem/Motivation

When viewing cards on this page, the "Learn more" links are not descriptive enough.
https://registrar.arizona.edu/faculty-staff-resources/room-course-scheduling/schedule-classes

Describe the bug

Card link text field should be more helpful for the content owner.

To Reproduce

Steps to reproduce the behavior:

  1. Create a card with a link
  2. Use screen reader to navigate to the clickable button
  3. Observe link text that is redundant and not explicit

Proposed resolution

  1. Add help text and/or warning to the card link text field
  2. Add link around the card title when using the stretched link

https://github.com/az-digital/az_quickstart/tree/issue/3396

Expected behavior

When using a screen reader, link should have useful context.

Additional context

Issue seen on both of these pages

@joeparsons joeparsons added bug Something isn't working enhancement New feature or request accessibility labels May 3, 2024
@danahertzberg danahertzberg linked a pull request May 16, 2024 that will close this issue
31 tasks
@danahertzberg
Copy link
Contributor Author

Updated the template, but unsure where to find just the URL to put in the path. Only find {{ link }} which is the URL and link title.

@danahertzberg
Copy link
Contributor Author

danahertzberg commented May 31, 2024

Add warning message if all cards have "read more" or same text in the link text field.

Update link URI here: https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_card/src/Plugin/Field/FieldFormatter/AZCardDefaultFormatter.php#L241-L247

  • ‘#link_url’ => $this->pathValidator->getUrlIfValid($item->link_uri ?? '<none>');
  • Basically you need to make the variable available to the template
  • [fieldname]_link_uri might work in the twig template.

Add link around heading and add help text to form. Warning not needed right now.

Add pattern and example to help text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants