Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to manage patches with cweagans/composer-patches 2.x (or alternative) #2612

Open
joeparsons opened this issue Jul 24, 2023 · 2 comments · May be fixed by az-digital/az-quickstart-scaffolding#144 or #3181
Open

Figure out how to manage patches with cweagans/composer-patches 2.x (or alternative) #2612

joeparsons opened this issue Jul 24, 2023 · 2 comments · May be fixed by az-digital/az-quickstart-scaffolding#144 or #3181
Assignees
@trackleft
Labels
dependencies Pull requests that update a dependency file spike Research required

Comments

@joeparsons
Copy link
Member

joeparsons commented Jul 24, 2023 •
edited
Loading

What is the problem that we want to solve?

The maintainer of cweagans/composer-patches has announced that the 2.0.0 version of his composer-patches plugin will no longer provide dependency patch resolution (i.e. discovering and applying patches defined by dependencies rather than in the root level composer.json file).
https://www.cweagans.net/2023/07/dependency-patch-resolution/

We currently rely heavily on this feature of composer-patches 1.x since we maintain most of our patches in the az-digital/az_quickstart repo which is used as a dependency in project-specific composer.json files (e.g. az-digital/az-quickstart-scaffolding and az-digital/az-quickstart-pantheon).

We'll need to figure out a plan for how to deal with this change. Some high-level options include:

  • Continue using composer-patches 1.x (which will stop being supported soon after 2.0.0 is released)
  • Create our own composer plugin that extends composer-patches 2.x to restore the dependency resolution functionality (or find a new composer plugin that extends composer-patches in this way)
  • Consider finding an alternative to cweagans/composer-patches
@joeparsons joeparsons added spike Research required dependencies Pull requests that update a dependency file labels Jul 24, 2023
@joeparsons
Copy link
Member Author

2023-07-26 Meeting discussion

@tadean pointed out that we don't actually need the full functionality provided by composer-patches. We really only need to apply patches from the az-digital/az_quickstart package so maintaining that functionality specifically might not be too complicated.

@trackleft Pointed out that some of our other az-digital projects also add patches (e.g. az-digital/az_google_cse)

@joeparsons
Copy link
Member Author

Promising new update from cweagans!
https://www.cweagans.net/2024/02/update-on-dependency-patch-resolution/

trackleft added a commit that referenced this issue Feb 16, 2024
@trackleft
Closes #2612 Upgrade cweagans/composer-patches to version 2
adeca98
@trackleft trackleft linked a pull request Feb 16, 2024 that will close this issue
Open
This was linked to pull requests Feb 16, 2024
Closes az-digital/az_quickstart/issues/2612 Upgrade cweagans/composer-patches to version 2 az-digital/az-quickstart-scaffolding#144
Open
On-Hold Closes #2612 Upgrade cweagans/composer-patches to version 2 #3181
Open
@joeparsons joeparsons moved this to In Progress in 2.10.0 Minor Release Feb 16, 2024
@trackleft trackleft linked a pull request Feb 21, 2024 that will close this issue
Open
27 tasks
@trackleft trackleft moved this from In Progress to Needs review in 2.10.0 Minor Release Feb 21, 2024
@joeparsons joeparsons moved this from Todo to Needs review in 2.11.0-alpha1 Mar 7, 2024
@danahertzberg danahertzberg added this to the 2.11.0 Stable Release milestone Apr 5, 2024
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Apr 9, 2024
@danahertzberg danahertzberg removed this from Roadmap Apr 15, 2024
@joeparsons joeparsons modified the milestones: 2.11.0 Stable Release, 2.12.0 Stable Release Jun 26, 2024
@joeparsons joeparsons removed this from the 2.12.0 Stable Release milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trackleft trackleft

Labels
dependencies Pull requests that update a dependency file spike Research required
Projects
2.13.0 Stable Release Issues
Status: No status
Milestone
No milestone
3 participants
@joeparsons @trackleft @danahertzberg