Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #261: Improve lando instructions in migration section of README #262

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maine-inventor
Copy link

@maine-inventor maine-inventor commented Jul 26, 2024

Section updated

Closes #261

@joeparsons joeparsons requested a review from a team July 26, 2024 19:51
@joeparsons joeparsons changed the title Added a few details to the Migration section regarding local Lando in… Closes #261: Improve lando instructions in migration section of README Jul 26, 2024
@joeparsons joeparsons added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 26, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@joeparsons
Copy link
Member

I think we also need to make some additional changes (could be in separate PRs):

  • I think we need a more generic "local development" section in the Pantheon upstream repo README. Maybe the migration instructions could be a sub-section of that?
  • The main Quickstart repo should also link to the Pantheon repo's Pantheon-specific lando instructions

README.md Outdated Show resolved Hide resolved
@joeparsons
Copy link
Member

Currently this document has these two migration headings:

## Determining whether the Quickstart 1 to Quickstart 2 migration path is viable for your site.
...
## Running migrations from Drupal 7 or UA Quickstart site downloaded from Pantheon, to Drupal 9 Arizona Quickstart site downloaded from Pantheon
...

I think we ought to consider changing the structure to be something like this:

## Using Lando for local development
(Put lando init instructions here)

## Migrating a Quickstart 1 Pantheon site to Quickstart 2

### Determining whether the Quickstart 2 migration path is viable for your site
...

### Running migrations locally using Lando 
(Add note to follow lando init instructions above)
...

@trackleft
Copy link
Member

See #144 as well

README.md Outdated Show resolved Hide resolved
@trackleft trackleft changed the base branch from master to prepare-2-11-4 September 30, 2024 20:35
Base automatically changed from prepare-2-11-4 to master October 1, 2024 20:10
An error occurred while trying to automatically change base from prepare-2-11-4 to master October 1, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions for setting up lando for Pantheon sites need work
4 participants