Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text-transform: uppercase from buttons #1245

Closed
caosborne89 opened this issue Jun 20, 2024 · 4 comments · Fixed by #1251
Closed

Remove text-transform: uppercase from buttons #1245

caosborne89 opened this issue Jun 20, 2024 · 4 comments · Fixed by #1251
Assignees

Comments

@caosborne89
Copy link

caosborne89 commented Jun 20, 2024

Motivation

All the button text styles are uppercase. It would be useful to add alternatives for each button style that removed the uppercase text-transformation.

Proposed Resolution

Add alternatives for each button style that does not include the uppercase text-transformation.

Updated approach: Update the default appearance of buttons to not include text-transform: uppercase, and include the change as part of the next minor release of AZ Bootstrap. We should also backport to 2.x.

@caosborne89 caosborne89 added the enhancement New feature or request label Jun 20, 2024
@camikazegreen
Copy link
Contributor

Screenshot 2024-06-18 at 8 25 35 AM

@caosborne89 caosborne89 transferred this issue from az-digital/az_quickstart Jun 21, 2024
@caosborne89 caosborne89 changed the title Add sentence case alternatives for the button text styles Add test-tranform none support for buttons Jun 21, 2024
@joshuasosa
Copy link

Sentence case is what Bootstrap uses by default:
https://getbootstrap.com/docs/4.6/components/buttons/
https://getbootstrap.com/docs/5.2/components/buttons/

Even if options are added, and a new class created, perhaps there should be consideration about changing the default off of all caps.

More reading:

@joeparsons joeparsons changed the title Add test-tranform none support for buttons Add text-tranform none support for buttons Jun 25, 2024
@akslay
Copy link
Contributor

akslay commented Jul 3, 2024

Bringing over some relevant notes from the conversations on this thread: https://uarizona.slack.com/archives/C0SAW6H4J/p1719869500798899

  • We'd like to change the default behavior but felt that was a change that probably necessitates a minor/major version bump of Arizona Bootstrap (which is something we haven't really done so far).
  • Should coincide with the release of AZ Quickstart 2.12.
  • Still need to decide how best to merge this change into AZ Bootstrap, but PR should be made against main branch (where all 5.x changes are too).
  • How to include that change into AZBS 2.x release (based on Bootstrap 4.x) will be a more complicated thing we'll need to figure out.

I will update the ticket description based on this information.

@akslay akslay self-assigned this Jul 3, 2024
@akslay akslay changed the title Add text-tranform none support for buttons Remove text-transform: uppercase from buttons Jul 3, 2024
@mmunro-ltrr
Copy link
Member

Backporting to the 2.x branch sounds like a good idea, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants