From 7232c3a99e3c0f4e5409f8069d3a9706e2d4736d Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 25 Oct 2017 10:02:54 +0200 Subject: [PATCH] src: remove superfluous HandleScope MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Accessors implicitly run inside a HandleScope, UDPWrap::GetFD() doesn't need to create one explicitly. PR-URL: https://github.com/nodejs/node/pull/16482 Reviewed-By: Franziska Hinkelmann Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Anna Henningsen --- src/udp_wrap.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc index efe6059084..d9dad98679 100644 --- a/src/udp_wrap.cc +++ b/src/udp_wrap.cc @@ -169,7 +169,6 @@ void UDPWrap::New(const FunctionCallbackInfo& args) { void UDPWrap::GetFD(Local, const PropertyCallbackInfo& args) { int fd = UV_EBADF; #if !defined(_WIN32) - HandleScope scope(args.GetIsolate()); UDPWrap* wrap = Unwrap(args.Holder()); if (wrap != nullptr) uv_fileno(reinterpret_cast(&wrap->handle_), &fd);