aya: tidy bpf syscalls and feature support functions into submodules #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tyrone-wu
force-pushed
the
aya/tidy-sys-funcs
branch
from
bda7c51
to
d445fa9
Compare
This organizes the bpf syscalls and feature probe functions in aya/src/sys/bpf.rs into submodules: btf, link, map, object, program, utils, and feature_probe. This is to help make development slightly less daunting to parse and expand on. The submodules, except for feature_probe, are re-exported so that importing them remains unchanged (i.e. crate::sys::foo). The feature probe submodule isn't re-exported (uses crate::sys::feature_probe::foo) so that there's some separation between bpf syscall stuff and feature probing.
tyrone-wu
force-pushed
the
aya/tidy-sys-funcs
branch
from
d445fa9
to
0c1d9f2
Compare
|
Actually on second thought, I don't think this is necessary. There's some things im looking at in aya-obj anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR organizes the bpf syscall related functions and feature support functions in
aya/src/sys/bpf.rsinto submodules:This is to help make development slightly less daunting to parse and expand on. For example, #959 would fit in
utils.rs, and additional feature detection stuff (like #957) would go infeature_probe.rs.This also updates all the imports that involve these submodules.
Still kind of a working progress with organizing the feature probe stuff.