Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asking for a magic string in BLS signature: where does it come from? #1508

Closed
yangby-cryptape opened this issue Oct 27, 2023 · 1 comment · Fixed by #1517
Closed

Asking for a magic string in BLS signature: where does it come from? #1508

yangby-cryptape opened this issue Oct 27, 2023 · 1 comment · Fixed by #1517
Assignees
Labels
t:help Extra attention is needed

Comments

@yangby-cryptape
Copy link
Collaborator

yangby-cryptape commented Oct 27, 2023

What happened

I met a problem to sync blocks from a observer node.

It throws an error of invalid signature.

When I tried to write a unit test, I found the magic string "axon".

Before the following line:

let res = signature.verify(&hash, &aggregate_key, &"axon".into());

There is no string of "axon" is used for creating the signature, why it is used for verifying the signature?

Where does this magic string come from?

I haven't found the original repository ophelia_blst (ref: #1507).

pub use ophelia_blst::{BlsPrivateKey, BlsPublicKey, BlsSignature};

@yangby-cryptape yangby-cryptape added the t:help Extra attention is needed label Oct 27, 2023
@KaoImin
Copy link
Contributor

KaoImin commented Oct 27, 2023

The origin source is here.
Axon used another bls library which need a common_ref to sign and verify. The current blst library doesn't need this. In order to keep the interface be same, we keep the argument, however, it's useless and we use "axon" to take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:help Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants