wrap prepared_ds_path in str() to avoid TypeError in fsspec package #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, could you see if the latest PR #1545 fixes it for you? |
8 tasks
That would probably fix it too, but I feel like it'd be better to fix the error in axolotl than to downgrade a dependency. |
winglian
approved these changes
Apr 21, 2024
`fsspec` calls `if "::" in path` on `prepared_ds_path`, which will throw an error if it is a `PosixPath` object.
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
…1548) * wrap prepared_ds_path in str() to avoid TypeError in fsspec package `fsspec` calls `if "::" in path` on `prepared_ds_path`, which will throw an error if it is a `PosixPath` object. * update test too --------- Co-authored-by: Wing Lian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1544
Motivation and Context
fsspeccallsif "::" in pathonprepared_ds_path, which will throw an error if it is aPosixPathobject.How has this been tested?
just a simple cast to string, but tested through cli preprocessing of a dataset and finetuning a model.
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)