-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otel, loki: support dynamic headers()
#334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
force-pushed
the
grpc-dynamic-headers
branch
from
October 11, 2024 13:09
cb5826a
to
618c0c3
Compare
This Pull Request introduces config grammar changesaxoflow/71be47e0d85d46e497584cf39d346164a7e0c89b -> alltilla/grpc-dynamic-headers --- a/destination
+++ b/destination
axosyslog-otlp(
+ frac-digits(<nonnegative-integer>)
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
+ local-time-zone(<string>)
+ on-error(<string>)
+ send-time-zone(<string>)
+ template-escape(<yesno>)
+ time-zone(<string>)
+ ts-format(<string>)
)
bigquery(
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
)
loki(
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
)
opentelemetry(
+ frac-digits(<nonnegative-integer>)
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
+ local-time-zone(<string>)
+ on-error(<string>)
+ send-time-zone(<string>)
+ template-escape(<yesno>)
+ time-zone(<string>)
+ ts-format(<string>)
)
syslog-ng-otlp(
+ frac-digits(<nonnegative-integer>)
headers(
- <string> => <string>
+ <string> => <template-content>
+ <string> => <template-reference>
)
+ local-time-zone(<string>)
+ on-error(<string>)
+ send-time-zone(<string>)
+ template-escape(<yesno>)
+ time-zone(<string>)
+ ts-format(<string>)
)
|
alltilla
added a commit
to alltilla/axosyslog
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
added a commit
to alltilla/axosyslog
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
grpc-dynamic-headers
branch
from
October 11, 2024 13:20
2888d8e
to
0839e8b
Compare
alltilla
added a commit
to alltilla/axosyslog
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
grpc-dynamic-headers
branch
from
October 11, 2024 13:32
0839e8b
to
5396b11
Compare
alltilla
added a commit
to alltilla/axosyslog
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
grpc-dynamic-headers
branch
from
October 11, 2024 13:46
5396b11
to
7b270ac
Compare
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Out intention is to batch messages that correspond to the same label set. If between two messages the label set changes, but they arrive to the same worker, we should flush the previous batch. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Will be useful for templated headers as well. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
This will be needed for the dynamic headers. Signed-off-by: Attila Szakacs <[email protected]>
It must be enabled in the derived class, and prepare_context_dynamic() must be used if so. This is not part of this commit, enabling it will be done in subsequent commits. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
grpc-dynamic-headers
branch
from
October 12, 2024 08:03
7b270ac
to
a12a4a8
Compare
I did not test this explicitly, but went through the commits and they all looked fine to me. |
bazsi
approved these changes
Oct 16, 2024
MrAnno
approved these changes
Oct 21, 2024
fekete-robert
pushed a commit
to axoflow/axosyslog-core-docs
that referenced
this pull request
Nov 9, 2024
fekete-robert
pushed a commit
to axoflow/axosyslog-core-docs
that referenced
this pull request
Nov 9, 2024
…opentelemetry destinations General options from axoflow/axosyslog#334
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.