lib/filterx: add startswith / endswith / includes functions #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverOrion
force-pushed
the
filterx-startswith-cached
branch
9 times, most recently
from
899e102
to
6319d72
Compare
bazsi
reviewed
Sep 20, 2024
bazsi
reviewed
Sep 20, 2024
bazsi
reviewed
Sep 20, 2024
OverOrion
force-pushed
the
filterx-startswith-cached
branch
4 times, most recently
from
bcf682b
to
3da97bf
Compare
OverOrion
changed the title
OverOrion
force-pushed
the
filterx-startswith-cached
branch
2 times, most recently
from
388c6ca
to
c6165b5
Compare
OverOrion
force-pushed
the
filterx-startswith-cached
branch
from
c6165b5
to
c87c606
Compare
OverOrion
force-pushed
the
filterx-startswith-cached
branch
from
c87c606
to
fd2a04d
Compare
OverOrion
commented
Sep 25, 2024
lib/filterx/func-str.c
Outdated
| if(self->str_len > G_MAXSSIZE) | ||
| return FALSE; | ||
|
|
||
| self->owned_str_value = g_utf8_casefold(self->borrowed_str_value, (gssize) self->str_len); |
There was a problem hiding this comment.
The official docs say for the deprecated strncasecmp:
[...] There are therefore two replacement techniques:
g_ascii_strncasecmp(), which only works on ASCII and is not locale-sensitive,and g_utf8_casefold() followed by strcmp() on the resulting strings, which is good for case-insensitive sorting of UTF-8.
OverOrion
force-pushed
the
filterx-startswith-cached
branch
2 times, most recently
from
112b464
to
2b30d3b
Compare
OverOrion
force-pushed
the
filterx-startswith-cached
branch
from
2b30d3b
to
cdef386
Compare
alltilla
reviewed
Sep 30, 2024
|
Sorry, there were some review comments stuck in from a previous session. Resolved everything that is already fixed. |
OverOrion
force-pushed
the
filterx-startswith-cached
branch
3 times, most recently
from
90c83b6
to
087a1ee
Compare
alltilla
reviewed
Oct 2, 2024
This will be used for startswith/endswith/includes functions Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
Signed-off-by: Szilard Parrag <[email protected]>
OverOrion
force-pushed
the
filterx-startswith-cached
branch
from
087a1ee
to
6f663ae
Compare
alltilla
approved these changes
Oct 2, 2024
fekete-robert
pushed a commit
to axoflow/axosyslog-core-docs
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init time optimized version of #277.
I opted for closing that because the changes are really different.