macros: extract type information from MESSAGE, PROGRAM and HOST #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
added a commit
to alltilla/axosyslog
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
fix-macro-expansion-type
branch
from
94df63b
to
ad5c5eb
Compare
MESSAGE in particular can contain not just string data, but for example JSON as well. This is necessary for the $(format-json) function to work properly with a json type MESSAGE. Kudos to b1oodborne from Discord for finding this issue. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
fix-macro-expansion-type
branch
from
ad5c5eb
to
5b6178e
Compare
bshifter
approved these changes
Jun 21, 2024
|
@bazsi Do you agree with this change? |
bazsi
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MESSAGEin particular can contain not just string data, but for example JSON as well.This is necessary for the
$(format-json)function to work properly with a json typeMESSAGE.Kudos to b1oodborne from Discord for finding this issue.
Signed-off-by: Attila Szakacs [email protected]