Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BridgeManager] Fix admin cannot interact with proxy register #270

Merged
merged 8 commits into from
Aug 16, 2023

Conversation

TuDo1403
Copy link
Contributor

@TuDo1403 TuDo1403 commented Aug 9, 2023

Description

This PR fix BridgeManagerCallbackRegister:notifyRegisters cannot interact with register if BridgeManager contract is TransparentUpgradeableProxyV2:admin of register.

Contract changes

The table below shows the following info:

  • Logic: the logic is changed.
  • ABI: the ABI is changed.
  • Init data: new storage field is declared and needs initializing.
  • Dependent: needs to be changed due to changes in other contracts.
Contract name Logic ABI Init data Dependent
RoninBridgeManager x
MainchainBridgeManager x
BridgeTracking
GovernanceAdmin
Maintenance
SlashIndicator
Staking
StakingVesting
ValidatorSet

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@TuDo1403 TuDo1403 changed the title fix: fix cannot notify proxy admin [BridgeManager] Fix admin cannot interact with proxy register Aug 14, 2023
@TuDo1403 TuDo1403 merged commit f3d7a90 into dev Aug 16, 2023
1 check failed
@nxqbao nxqbao deleted the fix/notify-proxy-admin-fail branch September 12, 2023 10:00
@nxqbao nxqbao restored the fix/notify-proxy-admin-fail branch September 12, 2023 10:01
@nxqbao nxqbao deleted the fix/notify-proxy-admin-fail branch October 21, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants