Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix assertion on arrays of BigNumbers #222

Merged
merged 1 commit into from
May 16, 2023

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented May 15, 2023

The hardhat-deploy package uses higher version of ethers which causes the following test case failed.

console.log(await validatorContract.getJailUntils(expectingValidatorSet));
console.log(BigNumber.from(blockNumber).add(jailDurationForUnavailabilityTier2Threshold));

Before upgrade

[ BigNumber { value: "57658" } ]
BigNumber { value: "57658" }

After upgrade

[ BigNumber { _hex: '0xe13a', _isBigNumber: true } ]
BigNumber { value: "57658" }

@nxqbao nxqbao merged commit db87bd4 into dev May 16, 2023
@nxqbao nxqbao deleted the package/remove-axie-packages branch July 5, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants