feat: starknet message_id and address format #726
+566
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctoyan
commented
Dec 14, 2024
There was a problem hiding this comment.
This MessageIdFormat is very similar to the HexTxHashAndEventIndex.
The main difference is that it's checking if the FieldElement (Felt) overflows.
Felt::MAX is 2^251+17*2^192+1, which fits in 252 bits. This means that a 64 hex string, representing 256 bits, might overflow it. We enforce 64 hex string everywhere with padded zeros.
If you find this check useless, I believe we can get rid of the custom message id format and re-use the HexTxHashAndEventIndex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR consists of:
voting-verifierCosmWASM contract changes, mostly related to MessageIdFormat and AddressFormatMessageIdFormat::FieldElementAndEventIndexandAddressFormat:StarknetTodos
Steps to Test
You would need the Starknet relayer, in order to manually test, which is not open sourced yet.
Also we don't have integration or end-to-end tests yet.
Expected Behaviour
Other Notes
Once this PR is merged and the changes related to the format are deployed on your devnet contracts, we'll re-test manually.