Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: connection router picks up gateway-api #277

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

fish-sammy
Copy link
Collaborator

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy requested a review from a team as a code owner February 21, 2024 17:52
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2644fba) 89.95% compared to head (87858ea) 89.96%.

Files Patch % Lines
packages/gateway-api/src/msg.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   89.95%   89.96%   +0.01%     
==========================================
  Files         165      165              
  Lines       16957    16956       -1     
==========================================
+ Hits        15254    15255       +1     
+ Misses       1703     1701       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy fish-sammy merged commit c454d48 into main Feb 21, 2024
6 of 7 checks passed
@fish-sammy fish-sammy deleted the AXE-3169-Connection-router-picks-up-gateway-api branch February 21, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants