-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make voting verifier generic #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgorenflo
approved these changes
Sep 19, 2023
fahimahmedx
changed the title
task: make voting verifier generic
refactor: make voting verifier generic
Sep 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 88.39% 88.34% -0.05%
==========================================
Files 110 110
Lines 10010 10015 +5
==========================================
Hits 8848 8848
- Misses 1162 1167 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cjcobb23
approved these changes
Sep 19, 2023
cjcobb23
pushed a commit
that referenced
this pull request
Sep 20, 2023
* rename EvmMessage to CrossChain Message * Generalize log_index to event_index * Rename EvmMessage struct * fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the voting-verifier to not be EVM specific to support the future Sui addition.
Todos
Steps to Test
Expected Behaviour
Other Notes
cargo test passes