Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make voting verifier generic #108

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

fahimahmedx
Copy link
Contributor

Description

Updates the voting-verifier to not be EVM specific to support the future Sui addition.

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

cargo test passes

@fahimahmedx fahimahmedx requested a review from a team as a code owner September 19, 2023 16:27
@fahimahmedx fahimahmedx changed the title task: make voting verifier generic refactor: make voting verifier generic Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #108 (0467059) into main (4082207) will decrease coverage by 0.05%.
The diff coverage is 75.75%.

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   88.39%   88.34%   -0.05%     
==========================================
  Files         110      110              
  Lines       10010    10015       +5     
==========================================
  Hits         8848     8848              
- Misses       1162     1167       +5     
Files Changed Coverage Δ
ampd/src/main.rs 0.00% <0.00%> (ø)
ampd/src/handlers/evm_verify_msg.rs 43.49% <50.00%> (-1.00%) ⬇️
ampd/src/evm/verifier.rs 98.88% <100.00%> (ø)
ampd/src/handlers/evm_verify_worker_set.rs 41.86% <100.00%> (ø)
contracts/voting-verifier/src/events.rs 96.26% <100.00%> (ø)
contracts/voting-verifier/src/execute.rs 96.66% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fahimahmedx fahimahmedx enabled auto-merge (squash) September 19, 2023 20:26
@fahimahmedx fahimahmedx merged commit 88d43ec into main Sep 19, 2023
5 of 7 checks passed
@fahimahmedx fahimahmedx deleted the AXE-1874-Make-voting-verifier-generic branch September 19, 2023 20:31
cjcobb23 pushed a commit that referenced this pull request Sep 20, 2023
* rename EvmMessage to CrossChain Message

* Generalize log_index to event_index

* Rename EvmMessage struct

* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants