Is there a plan to migrate ModifyVolumeProperties to ControllerModifyVolume？

[huchengze]

Since the ControllerModifyVolume in the CSI Spec is mature, is there a plan to migrate ModifyVolumeProperties to ControllerModifyVolume?
This way, the CSI driver would not need to integrate modify_grpc separately.

[torredil]

Hi @huchengze, the EBS CSI driver supports volume modification through the standardized CSI ControllerModifyVolume RPC: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/modify-volume.md

[fengye87]

Hi @torredil , I think this project could be generally useful for CSI driver implementations that would like to support modifying volumes via PVC annotations, especially for legacy Kubernetes versions where there's no VolumeAttributesClass support. But the problem is, I believe volume-modifier is now not calling the CSI spec standard ControllerModifyVolume method. Would it be acceptable to change it? If so, I would be happy to send a PR.

[huchengze]

Hi @torredil , I have submitted a PR to modify volumes using the K8s CSI controller client, and it is compatible with the existing RPC interface. Please take a look whenever you have time.

[torredil]

Thank you for the additional context @fengye87, and the request for review @huchengze.

I've forwarded this proposal to our internal team for consideration and review. We will provide an update directly on this issue as soon as one is available.