Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build on windows due to incorrect argument in ./web/package.json #63

Closed
scheurik opened this issue Apr 27, 2023 · 1 comment
Closed

Comments

@scheurik
Copy link
Collaborator

Current main branch does not build on Windows due incorrect argument in ./web/package.json with the "postinstall" scripts. Error can be seen when issuing "yarn install" command.

"Del" command must be replace with "del-cli"

Previous:
"postinstall": "patch-package && del ./node_modules/online-3d-viewer/libs/loaders/occt-import-js-worker.js && del ./node_modules/online-3d-viewer/libs/loaders/occt-import-js.js && del ./node_modules/online-3d-viewer/libs/loaders/occt-import-js.license.md && del ./node_modules/online-3d-viewer/libs/loaders/occt-import-js.wasm"

New:
"postinstall": "patch-package && del-cli ./node_modules/online-3d-viewer/libs/loaders/occt-import-js-worker.js && del-cli ./node_modules/online-3d-viewer/libs/loaders/occt-import-js.js && del-cli ./node_modules/online-3d-viewer/libs/loaders/occt-import-js.license.md && del-cli ./node_modules/online-3d-viewer/libs/loaders/occt-import-js.wasm"

@archieco
Copy link
Contributor

archieco commented May 9, 2023

Resolved by #64

@archieco archieco closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants