Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation tests #933

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

adamthom-amzn
Copy link
Contributor

Description of changes:
Fixes malformed request tests for validation:

  • An extra trailing = in the blob input made the blob content invalid, not too
    long for the constraint.

  • Query strings specified without an associated value map to empty string, not
    null. This means that they satisfy required constraints, and length constraints
    must be used to enforce that a value is specified when they have dynamic
    values.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

An extra trailing = in the blob input made the blob content invalid, not too
long for the constraint.
Query strings specified without an associated value map to empty string, not
null. This means that they satisfy required constraints, and length constraints
must be used to enforce that a value is specified when they have dynamic
values.
@adamthom-amzn adamthom-amzn requested a review from a team as a code owner October 9, 2021 01:35
@adamthom-amzn adamthom-amzn merged commit d8fdf44 into smithy-lang:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants