Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backward compat check and spec for paginated #716

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

mtdowling
Copy link
Member

Closes #712

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@kggilmer kggilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtdowling mtdowling force-pushed the add-paginated-backward-compat-checks branch from f57ff95 to d9182c5 Compare February 17, 2021 03:37
@mtdowling mtdowling force-pushed the add-paginated-backward-compat-checks branch from 84bac5a to 961d4fd Compare February 19, 2021 05:10
The diff.contents tag can now be used to make smithy-diff diff the
contents of a trait using diff.* tags. This allows for more granular
control over how more complex traits can evolve. Along with this change
comes simplifications to how modified trait messages are presented (the
shape is already part of the event and presentation, so there is no need
to repeat it in each diff message).
@mtdowling mtdowling force-pushed the add-paginated-backward-compat-checks branch from 961d4fd to ace51a1 Compare February 19, 2021 17:17
@mtdowling mtdowling merged commit bcd69b7 into main Feb 19, 2021
@kstich kstich mentioned this pull request Feb 22, 2021
@mtdowling mtdowling deleted the add-paginated-backward-compat-checks branch April 21, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc update request: Specify that changes to Paginator items trait is breaking
3 participants