Fix protocol test issues #692
Merged
+316
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
commented
Jan 22, 2021
mtdowling
force-pushed
the
protocol-test-fixes
branch
from
b785b7b
to
64d34c2
Compare
rcoh
reviewed
Jan 26, 2021
smithy-aws-protocol-tests/model/awsJson1_0/empty-input-output.smithy
Outdated
Show resolved
Hide resolved
mtdowling
force-pushed
the
protocol-test-fixes
branch
from
64d34c2
to
4b6a2ed
Compare
JordonPhillips
approved these changes
Jan 27, 2021
smithy-aws-protocol-tests/model/awsJson1_0/empty-input-output.smithy
Outdated
Show resolved
Hide resolved
mtdowling
force-pushed
the
protocol-test-fixes
branch
from
4b6a2ed
to
7d601df
Compare
JordonPhillips
approved these changes
Jan 28, 2021
This commit fixes various protocol test issues for AWS JSON 1.0, 1.1, and AWS REST JSON. In particular, this PR focuses on how request and response payloads are formed when there is no defined input, no defined output, an empty input, and an empty output. Various test cases have been added that are tagged as either client-only or server-only to ensure that both implementations are able to gracefully handle different cases like en empty JSON object sent as the payload, or omitting a payload altogether. These test cases are based on actual observed behavior of AWS services today. If we make changes to these protocols in the future, then we'll update the protocol tests to reflect them (e.g., maybe we add support for forcing an empty JSON object payload, omitting a payload, etc). Closes #686
mtdowling
force-pushed
the
protocol-test-fixes
branch
from
7d601df
to
b6ee466
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #686
Issue #, if available: 686
Description of changes:
This commit fixes various issues raised in #686. Some of this is related to just broken test cases (typically describing responses), and some of it is related to needing to indicate that a test case is meant to provide a client with an invalid response to ensure the client can gracefully handle it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.