Use list of string for queryParams #240
Merged
+56
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
approved these changes
Jan 3, 2020
mtdowling
force-pushed
the
fix-query-protocol-tests
branch
from
68cb6f4
to
82d60d0
Compare
queryParams in protocol compliance tests previously used a map of query string parameter names to values. However, this approach makes it impossible to define test cases for query string parameter lists where the serialized query string keys are repeated (which is the default serialization format used in Smithy HTTP protocol bindings). Now queryParams is a list of the query string parameter key value pairs (e.g., `queryParams: ["foo=bar", "foo=baz%20bam"]`. This allows for testing any kind of query string serialization format, including repeated key parameters.
mtdowling
force-pushed
the
fix-query-protocol-tests
branch
from
82d60d0
to
7de413d
Compare
kstich
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queryParams in protocol compliance tests previously used a map of query
string parameter names to values. However, this approach makes it
impossible to define test cases for query string parameter lists where
the serialized query string keys are repeated (which is the default
serialization format used in Smithy HTTP protocol bindings).
Now queryParams is a list of the query string parameter key value pairs
(e.g.,
queryParams: ["foo=bar", "foo=baz%20bam"]. This allows for testingany kind of query string serialization format, including repeated key
parameters.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.