(doc): Minor rephrase for Timestamp description. #1835
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Jun 30, 2023
docs/source-2.0/spec/model.rst
Outdated
| @@ -789,7 +789,7 @@ target from traits and how their values are defined in | |||
| - number | string | |||
| - If a number is provided, it represents Unix epoch seconds with optional | |||
| millisecond precision. If a string is provided, it MUST be a valid | |||
| :rfc:`3339` string with no UTC offset and optional fractional | |||
| :rfc:`3339` string with optional fractional precision but no UTC offset | |||
There was a problem hiding this comment.
Looks like the next line still has the word "precision", but should not
There was a problem hiding this comment.
Makes sense, updated. Thanks!
karthikbekalp
force-pushed
the
MinorTimeStampDocRephraze
branch
from
f2fe535
to
77d6bb7
Compare
mtdowling
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Minor timestamp description update.
Description of changes:
The description was slightly confusing as I thought it was no (UTC offset and fractional milliseconds) instead of (no UTC) and (fractional milliseconds).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.