Document changeStringEnumsToEnumShapes transformer #1740
Merged
+143
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Apr 19, 2023
srchase
force-pushed
the
string-to-enum-transform-docs
branch
from
83e0118
to
fcc6aff
Compare
gosar
approved these changes
Apr 20, 2023
mtdowling
reviewed
Apr 20, 2023
|
This transform is available to 1.0 IDL too, since we load everything as 2.0 and serialize as 2.0 anyways. Should we document this in the 1.0 docs too? |
srchase
force-pushed
the
string-to-enum-transform-docs
branch
from
fcc6aff
to
77df48d
Compare
srchase
force-pushed
the
string-to-enum-transform-docs
branch
from
4e6a2da
to
124763e
Compare
srchase
force-pushed
the
string-to-enum-transform-docs
branch
from
124763e
to
c6c5dcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docs for changeStringEnumsToEnumShapes transformer, including behavior from #1739
Additionally, it updates the
changeTypesdocumentation to include its ability to transform Strings with@enumtraits to Enums.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.