Add rudimentary form of error recovery to parser #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
error-recovery
branch
from
a4c906d
to
4f9c4c6
Compare
mtdowling
force-pushed
the
error-recovery
branch
2 times, most recently
from
c882606
to
3e6cd35
Compare
JordonPhillips
requested changes
Apr 18, 2023
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelLoader.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/resources/software/amazon/smithy/model/loader/error-recovery.smithy
Outdated
Show resolved
Hide resolved
mtdowling
force-pushed
the
error-recovery
branch
from
3e6cd35
to
2a00227
Compare
JordonPhillips
approved these changes
Apr 19, 2023
When we encounter a parser error, we'll now attempt some basic error recovery by simply skipping token until we reach a token at the start of a line that is an identifier, documentation comment, or '@'. This should help with things like LSPs that still should be able to utilize jump to definition even with a broken or in-progress model. Add error recovery to control statements and metadata. Ensure that invalid identifiers are turned into ERROR tokens instead of throwing. Error recovery will also consider "$" a recovery token.
mtdowling
force-pushed
the
error-recovery
branch
from
6e89ada
to
d1ebe68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we encounter a parser error, we'll now attempt some basic error recovery by simply skipping token until we reach a token at the start of a line that is an identifier, documentation comment, or '@'. This should help with things like LSPs that still should be able to utilize jump to definition even with a broken or in-progress model.
(still need to test the experience out in the LSP before merging)