Allow error rename and disallow error rename for all AWS protocols #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
force-pushed
the
error-rename
branch
9 times, most recently
from
fa4f969
to
da8d246
Compare
mtdowling
requested changes
Dec 21, 2022
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ErrorRenameValidator.java
Show resolved
Hide resolved
...y-aws-traits/src/main/java/software/amazon/smithy/aws/traits/protocols/AwsProtocolTrait.java
Outdated
Show resolved
Hide resolved
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ErrorRenameValidator.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
error-rename
branch
3 times, most recently
from
0f8cb89
to
c9f6c85
Compare
srchase
reviewed
Dec 22, 2022
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ErrorRenameValidator.java
Outdated
Show resolved
Hide resolved
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ErrorRenameValidator.java
Outdated
Show resolved
Hide resolved
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ErrorRenameValidator.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
error-rename
branch
from
c9f6c85
to
f93c791
Compare
mtdowling
requested changes
Jan 3, 2023
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ErrorRenameValidator.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
error-rename
branch
2 times, most recently
from
9f12b31
to
f300307
Compare
AndrewFossAWS
changed the title
AndrewFossAWS
commented
Jan 4, 2023
|
|
||
| By default, Smithy permits renaming shapes to disambiguate shape ID conflicts in | ||
| the :ref:`service closure <service-closure>` via the ``rename`` property. However, services using this protocol are | ||
| not allowed to rename error shapes (shapes with :ref:`error trait <error-trait>` applied). |
There was a problem hiding this comment.
This will be removed later when AWS SDKs have been verified to support error shape rename.
AndrewFossAWS
force-pushed
the
error-rename
branch
from
f300307
to
c6cc174
Compare
mtdowling
approved these changes
Jan 4, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1545
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.