Update smithy-diff for strings with the enum trait to enum shapes #1409
+516
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
smithy-diff-noise-cleanup
branch
3 times, most recently
from
f0def3c
to
0d27829
Compare
syall
changed the title
sugmanue
reviewed
Sep 20, 2022
smithy-diff/src/test/java/software/amazon/smithy/diff/evaluators/ChangedEnumTraitTest.java
Show resolved
Hide resolved
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/AddedShape.java
Outdated
Show resolved
Hide resolved
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/AddedShape.java
Outdated
Show resolved
Hide resolved
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/AddedShape.java
Outdated
Show resolved
Hide resolved
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/ChangedShapeType.java
Outdated
Show resolved
Hide resolved
sugmanue
reviewed
Sep 20, 2022
smithy-diff/src/test/java/software/amazon/smithy/diff/evaluators/ChangedEnumTraitTest.java
Outdated
Show resolved
Hide resolved
smithy-diff/src/test/java/software/amazon/smithy/diff/evaluators/ChangedShapeTypeTest.java
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
smithy-diff-noise-cleanup
branch
2 times, most recently
from
309d92e
to
a179744
Compare
sugmanue
approved these changes
Sep 21, 2022
Remove the following noise from smithy-diff: - Errors for changing shape type from strings with the `enum` trait to enum shapes since the `enum` trait is deprecated. - Notes for members added to the converted enum shapes. Updated `ChangedEnumTrait` to not just compare changed `enum` traits, but also changes of an `enum` trait to its converted enum shape.
syall
force-pushed
the
smithy-diff-noise-cleanup
branch
from
a179744
to
bc7bd4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Update smithy-diff for strings with the enum trait to enum shapes
Remove the following noise from smithy-diff:
enumtrait to enum shapes since theenumtrait is deprecated.Updated
ChangedEnumTraitto not just compare changedenumtraits, but also changes of anenumtrait to its converted enum shape.Testing:
./gradlew clean build check :smithy-cli:runtimeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.