Disallow sensitive trait on members #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing @sensitive trait on members can lead to insecure usage patterns, like forgetting to put @sensitive on ALL members that target the same shape, which can lead to sensitive data not getting handled properly, e.g., not getting redacted from logs, etc. Instead marking the target shape as sensitive prevents modeling mistakes by ensuring every reference to data types that are inherently sensitive are always considered sensitive.
srchase
force-pushed
the
disallow-sensitive-trait-on-members
branch
from
88fe681
to
38d54ca
Compare
gosar
approved these changes
Jun 10, 2022
gosar
added a commit
to gosar/smithy-typescript
that referenced
this pull request
Aug 17, 2022
Based on smithy-lang/smithy#1226 from Smithy 1.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the change from #1137 to the main branch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.