Register formatter #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
register-formatter
branch
from
5c24846
to
acb4faa
Compare
JordonPhillips
approved these changes
Mar 16, 2023
| const range = edit.range; | ||
| const newText = edit.newText; | ||
|
|
||
| assert.equal(edits.length, 1); |
There was a problem hiding this comment.
Is this going to be one edit per file, or is it smaller chunks than that? If the latter I'd be a bit worried about saying exactly one in case things change.
There was a problem hiding this comment.
test-fixtures/suite5/smithy/main.smithy should just need the one line indented, resulting in a single edit being returned from the Language Server. If there were multiple changes needed to format it properly, there could potentially be multiple edits returned.
I could loosen this test just to check that at least one edit is returned, and not assert anything further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers the Smithy formatter added in smithy-lang/smithy-language-server#89.
WIP until version
0.2.3of the Smithy Language Server has been published.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.