-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add root path configuration #54
feat: add root path configuration #54
Conversation
@@ -1,6 +1,6 @@ | |||
{ | |||
"maven": { | |||
"dependencies": ["software.amazon.smithy:smithy-aws-traits:1.23.1"], | |||
"dependencies": ["software.amazon.smithy:smithy-aws-traits:1.25.0", "software.amazon.smithy:smithy-waiters:1.25.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does smithy-waiters
need to be pulled in for this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to ensure we were testing minimally 2 packages being installed.
Thank you for separating the PRs, they have been merged. Please rebase and push this branch back up to avoid conflict. |
7e911cd
to
3cfdbcf
Compare
Issue #, if available: N/A
Description of changes:
Allow users to customize the root path to be used by the Smithy VSCode extension. Otherwise, whenever we have the
smithy-build.json
file not in the workspace root, it fails with the following (as per commit 6e8f997):Dump from .smithy.lsp.log
[18:14:14] Created a temporary folder for file contents /var/folders/dc/07t_8b2n41lgnz09y651104w0000gn/T/smithy-lsp7987430497366641088
[18:14:14] Recreating project from /smithy-vscode/test-fixtures/suite1
[18:14:14] Imports from config: [/smithy-vscode/test-fixtures/suite1] will be resolved against root /smithy-vscode/test-fixtures/suite1
[18:14:14] Discovered smithy files: [/smithy-vscode/test-fixtures/suite1/smithy/main.smithy]
[18:14:14] Downloading external dependencies for SmithyBuildExtensions(repositories = [], artifacts = [], imports = [])
[18:14:14] Downloaded external jars: []
[18:14:14] [ERROR] example.weather#GetCurrentTime: Unable to resolve trait
aws.api#dataPlane
. If this is a custom trait, then it must be defined before it can be used in a model. | Model /smithy-vscode/test-fixtures/suite1/smithy/main.smithy:18:1[18:14:14] [ERROR] example.weather#Weather: Unable to resolve trait
aws.api#service
. If this is a custom trait, then it must be defined before it can be used in a model. | Model /smithy-vscode/test-fixtures/suite1/smithy/main.smithy:9:1[18:14:14] Recreating project from /smithy-vscode/test-fixtures/suite1
[18:14:14] Imports from config: [/smithy-vscode/test-fixtures/suite1] will be resolved against root /smithy-vscode/test-fixtures/suite1
[18:14:14] Discovered smithy files: [/smithy-vscode/test-fixtures/suite1/smithy/main.smithy]
[18:14:14] Downloading external dependencies for SmithyBuildExtensions(repositories = [], artifacts = [], imports = [])
[18:14:14] Downloaded external jars: []
[18:14:14] [ERROR] example.weather#GetCurrentTime: Unable to resolve trait
aws.api#dataPlane
. If this is a custom trait, then it must be defined before it can be used in a model. | Model /smithy-vscode/test-fixtures/suite1/smithy/main.smithy:18:1[18:14:14] [ERROR] example.weather#Weather: Unable to resolve trait
aws.api#service
. If this is a custom trait, then it must be defined before it can be used in a model. | Model /smithy-vscode/test-fixtures/suite1/smithy/main.smithy:9:1[18:14:14] [ERROR] example.weather#GetCurrentTime: Unable to resolve trait
aws.api#dataPlane
. If this is a custom trait, then it must be defined before it can be used in a model. | Model /smithy-vscode/test-fixtures/suite1/smithy/main.smithy:18:1[18:14:14] [ERROR] example.weather#Weather: Unable to resolve trait
aws.api#service
. If this is a custom trait, then it must be defined before it can be used in a model. | Model /smithy-vscode/test-fixtures/suite1/smithy/main.smithy:9:1[18:14:14] Recompiling /smithy-vscode/test-fixtures/suite1/smithy/main.smithy (with temporary content Optional.empty) raised 2 diagnostics
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.