feat(experimentalIdentityAndAuth): add more auth traits to generic client tests #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
update-generic-client-test-auth
branch
from
b019a46 to
b3cf777
Compare
syall
force-pushed
the
update-generic-client-test-auth
branch
from
b3cf777 to
c36c03e
Compare
kuhe
approved these changes
Aug 18, 2023
syall
force-pushed
the
update-generic-client-test-auth
branch
from
c36c03e to
6768366
Compare
added 2 commits
August 18, 2023 10:43
…ient tests Note that the `smithy-aws-traits` dependency is added for including `@aws.auth#sigv4`, which will have generic client support. This should not affect packaging of `smithy-typescript-codegen` since these tests are in `smithy-typescript-codegen-test`.
syall
force-pushed
the
update-generic-client-test-auth
branch
from
6768366 to
dfa8bef
Compare
srchase
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Add more auth traits to generic client tests.
Note that the
smithy-aws-traitsdependency is added for including@aws.auth#sigv4, which will have generic client support. This shouldnot affect packaging of
smithy-typescript-codegensince these testsare in
smithy-typescript-codegen-test.Also, simplify
AddHttpApiKeyAuthPlugincontrol path for computing whether@httpApiKeyAuthis supported on a service and operation.If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.