pagination: omit aggregated client in paginators #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Mar 7, 2023
kstich
approved these changes
Mar 7, 2023
1 task
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* pagination: omit aggregated client in paginators * pagination: exclude aggregated client from pagination interface
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for aws/aws-sdk-js-v3#3093
Current paginators use a method based request if the client that is provided by the user is the aggregated client type.
This is not necessary because the aggregated client extends the barebones client and can still make Command-based requests with
.send().Inclusion of the aggregated client is detrimental because it imports all commands (and thus protocols/models) in a given service, increasing bundle size.