Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use util-base64 in ServerGenerator #631

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Use util-base64 in ServerGenerator #631

merged 1 commit into from
Nov 9, 2022

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 9, 2022 •
edited
Loading

Issue #, if available:
Internal JS-3705

Description of changes:
Use util-base64 in ServerGenerator.

In AWS SDK for JavaScript (v3) clients, the change was done in aws/aws-sdk-js-v3#4140

Testing:

Verified that tests pass for server artifacts:

$ aws-sdk-js-v3> yarn generate-clients --server-artifacts

$ aws-sdk-js-v3> yarn test:server-protocols
...
lerna success run Ran npm script 'test' in 2 packages in 15.2s:
lerna success - @aws-sdk/aws-restjson-server
lerna success - @aws-sdk/aws-restjson-validation-server
Done in 49.06s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review November 9, 2022 21:04
@trivikr trivikr requested a review from a team as a code owner November 9, 2022 21:04
syall
syall approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@syall syall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, AWS_SDK_UTIL_BASE64 is safe to use since it merges Node and browser implementations, so it does not need to target node specific dependency anymore.

@trivikr trivikr merged commit 42ca023 into smithy-lang:main Nov 9, 2022
@trivikr trivikr deleted the util-base64-server-generator branch November 9, 2022 21:17
milesziemer pushed a commit to milesziemer/smithy-typescript that referenced this pull request Dec 14, 2022
@trivikr @milesziemer
Use util-base64 in ServerGenerator (smithy-lang#631)
48a6d2c
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
@trivikr @srchase
Use util-base64 in ServerGenerator (smithy-lang#631)
35b5d91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syall syall syall approved these changes

@kuhe kuhe kuhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivikr @kuhe @syall