Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): expand custom endpoint type #622

Merged
merged 1 commit into from
Oct 26, 2022
Merged

fix(types): expand custom endpoint type #622

merged 1 commit into from
Oct 26, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 26, 2022

override the type of endpoint in endpoint params to string|Endpoint|EndpointV2 instead of only string

@kuhe kuhe requested a review from a team as a code owner October 26, 2022 15:21
@kuhe kuhe merged commit 8191c6a into smithy-lang:main Oct 26, 2022
@kuhe kuhe deleted the fix/endpoint-type branch October 26, 2022 16:29
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
@kuhe @srchase
fix(types): expand custom endpoint type (smithy-lang#622)
503ba4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @trivikr