Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codegen comment to top of files #538

Merged
merged 3 commits into from
May 5, 2022
Merged

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Apr 27, 2022

Simpler version of #535, adds a comment to files indicating generated code to discourage direct modification.

For detailed debugging, use the feature from smithy-lang/smithy#1198

SDK changes: aws/aws-sdk-js-v3#3592

@kuhe kuhe added the enhancement New feature or request label Apr 27, 2022
@kuhe kuhe requested a review from a team as a code owner April 27, 2022 18:48
@kuhe
Copy link
Contributor Author

kuhe commented May 3, 2022

do I need to simultaneously merge the generate-clients diff into v3?

edit: yes

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship again!

@kuhe kuhe merged commit c3ef952 into smithy-lang:main May 5, 2022
@kuhe kuhe deleted the attribution-r2 branch May 5, 2022 15:18
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
* add codegen comment to top of files

* unversion Makefile

* check for ts(x) extension before adding codegen attribution comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants