Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move SSDK source code to 'src' folder #437

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Sep 30, 2021

Issue #, if available:
Fixes server protocol tests.
Example failure: https://github.com/aws/aws-sdk-js-v3/runs/3747465220

Description of changes:
Move SSDK source code to 'src' folder

Testing:

Verified that source files are generated in "src" folder and build is successful.

The tests fails with the following error, but it's unrelated to moving source code to 'src' folder in protocol_tests/aws-restjson-server

lerna ERR! yarn run build exited 2 in '@aws-sdk/aws-restjson-server'
lerna ERR! yarn run build stdout:
$ yarn build:cjs && yarn build:es && yarn build:types
$ tsc -p tsconfig.json
src/protocols/Aws_restJson1.ts(38,3): error TS2305: Module '"@aws-smithy/server-common"' has no exported member 'acceptMatches'.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore: move SSDK source code to 'src' folder fix: move SSDK source code to 'src' folder Sep 30, 2021
@trivikr trivikr marked this pull request as ready for review September 30, 2021 16:08
@AllanZhengYP AllanZhengYP merged commit 12cba2b into smithy-lang:main Sep 30, 2021
@trivikr trivikr deleted the ssdk-move-source-folder-to-src branch September 30, 2021 16:40
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
* chore: prefix 'src' in ServerSymbolVisitor

* chore: prefix 'src' for server/index.ts

* chore: prefix 'src' for protocols import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants